fix(streaming): move error event check before thread.* handling#2807
Open
yurekami wants to merge 1 commit intoopenai:mainfrom
Open
fix(streaming): move error event check before thread.* handling#2807yurekami wants to merge 1 commit intoopenai:mainfrom
yurekami wants to merge 1 commit intoopenai:mainfrom
Conversation
The `sse.event == "error"` check was unreachable inside the
`sse.event.startswith("thread.")` block since a string cannot
simultaneously equal "error" and start with "thread.".
This moves error event handling to a separate check before the
thread.* event handling, ensuring error events are properly caught
and raise APIError.
Fixes openai#2796
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2796
The
sse.event == "error"check inside thesse.event.startswith("thread.")block was unreachable dead code, since a string cannot simultaneously equal"error"and start with"thread.".Changes
sse.event == "error") to a separate check before thethread.*event handlingStream.__stream__) and async (AsyncStream.__stream__) implementationsiftoeliffor thethread.*check to maintain proper control flowBefore
After
Test Plan
🤖 Generated with Claude Code