fix: handle all web_search actions and in progress invocations#9960
Merged
fix: handle all web_search actions and in progress invocations#9960
Conversation
pakrym-oai
reviewed
Jan 27, 2026
pakrym-oai
reviewed
Jan 27, 2026
pakrym-oai
reviewed
Jan 27, 2026
pakrym-oai
reviewed
Jan 27, 2026
| let original_value: serde_json::Value = serde_json::from_str(json_literal)?; | ||
| assert_eq!(serialized, original_value); | ||
| let mut expected_serialized: serde_json::Value = serde_json::from_str(json_literal)?; | ||
| if !expect_roundtrip && let Some(obj) = expected_serialized.as_object_mut() { |
Collaborator
There was a problem hiding this comment.
Why don't we expect roundtrip?
Collaborator
Author
There was a problem hiding this comment.
id isnt serialized on WebSearchCall so it's not present after serialization
pakrym-oai
reviewed
Jan 27, 2026
pakrym-oai
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web_searchtool actions (search,find_in_page,open_page).search, which made the TUI appear to pause when the other actions were being used.web_searchcalls asSearching the webTests
Added + updated tests, tested locally
Follow ups
Update VSCode extension to display these as well