feat: load interface metadata from SKILL.json#9953
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15500f7ea4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/skills/loader.rs
Outdated
| let interface = match parsed.interface { | ||
| Some(interface) => interface, | ||
| None => return None, | ||
| }; |
There was a problem hiding this comment.
In load_skill_interface, if a SKILL.json file exists but omits the interface key, the code returns None immediately instead of continuing to the SKILL.toml fallback (parsed.interface → None => return None). This means a placeholder/empty SKILL.json (or a future extension file without interface) will silently suppress otherwise valid interface metadata in SKILL.toml, which is a regression from the previous behavior and contradicts the “fail open” goal. Consider continue here so the loader still tries TOML when JSON has no interface block.
Useful? React with 👍 / 👎.
2 participants
No description provided.