Reuse ChatComposer in request_user_input overlay#9892
Merged
aibrahim-oai merged 6 commits intomainfrom Jan 27, 2026
Merged
Conversation
Collaborator
Author
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3989b975ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Add in-code docs that explain the composer reuse approach and paste-burst routing. - Document paste-burst hooks on BottomPaneView and the view-first flush checks. - Clarify request_user_input layout choices (notes sizing and footer override).
aibrahim-oai
force-pushed
the
rdi/request-user-input-composer
branch
from
623c88e to
d4a73fe
Compare
charley-oai
reviewed
Jan 27, 2026
| let answer = self.current_answer_mut()?; | ||
| if !has_options { | ||
| return Some(&mut answer.notes); | ||
| fn save_current_draft(&mut self) { |
Collaborator
There was a problem hiding this comment.
Large pastes can be lost when switching questions.
- save_current_draft() captures current_text() but not pending paste payloads: codex-rs/tui/src/bottom_pane/request_user_input/mod.rs:167
- Restoring uses set_text_content(...), which clears pending_pastes: codex-rs/tui/src/bottom_pane/chat_composer.rs:652
- Final submission reads answer_state.draft.text: codex-rs/tui/src/bottom_pane/request_user_input/mod.rs:316
- Suggestion: use current_text_with_pending() (codex-rs/tui/src/bottom_pane/chat_composer.rs:620) or expose a “flush pending pastes into text” helper before saving drafts.
charley-oai
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the shared chat composer for notes and freeform answers in request_user_input.