Skip to content

Add composer config and shared menu surface helpers#9891

Merged
aibrahim-oai merged 4 commits intomainfrom
rdi/composer-config-surface
Jan 26, 2026
Merged

Add composer config and shared menu surface helpers#9891
aibrahim-oai merged 4 commits intomainfrom
rdi/composer-config-surface

Conversation

@aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Jan 26, 2026

Centralize built-in slash-command gating and extract shared menu-surface helpers.

  • Add bottom_pane::slash_commands and reuse it from composer + command popup.
  • Introduce ChatComposerConfig + shared menu surface rendering without changing default behavior.

@aibrahim-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Collaborator

@charley-oai charley-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ask codex to update docs/tui-chat-composer.md to mention the new config gating? I think that's in AGENTS.md. Also there's a merge conflict

“Update the narrative doc docs/tui-chat-composer.md whenever behavior/assumptions change (Enter handling, retro-capture, flush/clear rules, disable_paste_burst, non-ASCII/IME handling).”

@aibrahim-oai aibrahim-oai enabled auto-merge (squash) January 26, 2026 23:11
@aibrahim-oai aibrahim-oai merged commit a8f1958 into main Jan 26, 2026
32 checks passed
@aibrahim-oai aibrahim-oai deleted the rdi/composer-config-surface branch January 26, 2026 23:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants