Fix: Lower log level for closed-channel send#9653
Merged
etraut-openai merged 1 commit intoopenai:mainfrom Jan 22, 2026
Merged
Conversation
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Kbediako
changed the title
etraut-openai
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
codex-rs/core/src/codex.rs.Why?
async_channel::Sender::sendonly fails when the channel is closed, so the current error-level log is noisy during normal shutdown. See issue Bug: Error log when collab event channel closes on shutdown #9652.How?
Tests
just fmtjust fix -p codex-corecargo test -p codex-core