Skip to content

Restore image attachments/text elements when recalling input history (Up/Down)#9628

Merged
charley-oai merged 3 commits intomainfrom
save-text-elements-in-input-history
Jan 28, 2026
Merged

Restore image attachments/text elements when recalling input history (Up/Down)#9628
charley-oai merged 3 commits intomainfrom
save-text-elements-in-input-history

Conversation

@charley-oai
Copy link
Collaborator

Summary

  • Up/Down input history now restores image attachments and text elements for local entries.
  • Composer history stores rich local entries (text + text elements + local image paths) while persistent history remains text-only.
  • Added tests to verify history recall rehydrates image placeholders and attachments in both tui and tui2.

Changes

  • tui/src/bottom_pane/chat_composer_history.rs: store HistoryEntry (text + elements + image paths) for local history; adapt navigation + tests.
  • tui2/src/bottom_pane/chat_composer_history.rs: same as above.
  • tui/src/bottom_pane/chat_composer.rs: record rich history entries and restore them on Up/Down; update Ctrl+C history and tests.
  • tui2/src/bottom_pane/chat_composer.rs: same as above.

@charley-oai
Copy link
Collaborator Author

@codex review this

@charley-oai charley-oai changed the base branch from main to save-text-elements-in-user-input January 21, 2026 20:40
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 821f480fee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai force-pushed the save-text-elements-in-user-input branch from b3aa0f2 to aebb2f3 Compare January 22, 2026 18:03
Base automatically changed from save-text-elements-in-user-input to main January 23, 2026 18:18
@charley-oai charley-oai force-pushed the save-text-elements-in-input-history branch from a340b14 to ba9cfed Compare January 24, 2026 17:51
@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai force-pushed the save-text-elements-in-input-history branch from ba9cfed to 2f6cec1 Compare January 25, 2026 05:13
@charley-oai charley-oai force-pushed the save-text-elements-in-input-history branch from 2f6cec1 to c617e93 Compare January 28, 2026 01:04
@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai merged commit add648d into main Jan 28, 2026
33 checks passed
@charley-oai charley-oai deleted the save-text-elements-in-input-history branch January 28, 2026 02:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants