define/emit some metrics for windows sandbox setup#9573
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5499e7991a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Why would this live in the TUI? I feel like we want it in core/ to make sure we capture as much surfaces as possible
|
@jif-oai definitely - only added to the TUI here for simplicity because these screens/interactions only live in the TUI. Will plan to move them somewhere "shared" when we start adding screens to the extension/app/etc. and we introduce a better place for them. |
jif-oai
left a comment
jif-oai
left a comment
There was a problem hiding this comment.
Good for now then but in the future this should live where the events are emitted...
3 participants
This should give us visibility into how users are using the elevated sandbox nux flow, and the timing of the elevated setup.