Conversation
owenlin0
force-pushed
the
owen/thread_read_api
branch
2 times, most recently
from
c78e466 to
f78833a
Compare
owenlin0
force-pushed
the
owen/thread_read_api
branch
from
f78833a to
5d06347
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d063473e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let rollout_path = | ||
| match find_thread_path_by_id_str(&self.config.codex_home, &thread_uuid.to_string()) | ||
| .await | ||
| { |
There was a problem hiding this comment.
When a thread is archived, its rollout file is moved into archived_sessions (see codex_message_processor.rs:3261-3268). thread/read resolves the rollout path solely via find_thread_path_by_id_str, which only searches under codex_home/sessions (core/src/rollout/list.rs:798-820). This means a thread that was successfully archived will now fail thread/read with “no rollout found”, even though the data is still stored; the new API can’t read archived threads at all. Consider falling back to a search in archived_sessions (or adding an explicit flag) so archived threads remain readable.
Useful? React with 👍 / 👎.
2 participants
Add a new
thread/readapp-server API for fetching a thread (and optionally also include the thread's contents via theturnsfield).