Skip to content

Reject ask user question tool in Execute and Custom#9560

Merged
charley-oai merged 4 commits intomainfrom
reject-ask-user-question-tool-in-exec-and-custom
Jan 21, 2026
Merged

Reject ask user question tool in Execute and Custom#9560
charley-oai merged 4 commits intomainfrom
reject-ask-user-question-tool-in-exec-and-custom

Conversation

@charley-oai
Copy link
Collaborator

Summary

  • Keep request_user_input in the tool list but reject it at runtime in Execute/Custom modes with a clear model-facing error.
  • Add a session accessor for current collaboration mode and enforce the gate in the request_user_input handler.
  • Update core/app-server tests to use Plan mode for success and add Execute/Custom rejection coverage.

@charley-oai
Copy link
Collaborator Author

@codex review this

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charley-oai charley-oai marked this pull request as ready for review January 21, 2026 02:05
Copy link
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@charley-oai charley-oai merged commit 0523a25 into main Jan 21, 2026
28 of 32 checks passed
@charley-oai charley-oai deleted the reject-ask-user-question-tool-in-exec-and-custom branch January 21, 2026 02:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants