Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9da8049369
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
It may be worth considering writing the excess output to a file (noting it at the end of the output), and putting a hard cap on the file output (user configurable with a sane default - say 100MB or something like that). Ideally this would allow codex to follow up by reading the leftover file as needed (rg / sed to do portions).
Not a blocker - just possible follow up (and may be necessary for some user flows that expect large outputs from cli tools).
Co-authored-by: Josh McKinney <joshka@openai.com>
3 participants
No description provided.