[device-auth] Add device code auth as a standalone option when headless environment is detected.#9333
Merged
mzeng-openai merged 4 commits intomainfrom Jan 16, 2026
Merged
Conversation
joshka-oai
approved these changes
Jan 16, 2026
Collaborator
joshka-oai
left a comment
joshka-oai
left a comment
There was a problem hiding this comment.
Can this be tested simply? (e.g. Codex "add unit tests that use insta to check the output of these screens for the various combinations. Ideally these tests should be phrased as simple explanations of the behavior").
I suspect the animation may make this non-trivial, but there's a way to ignore parts of an output in insta (IIRC).
| self.request_frame.schedule_frame(); | ||
| } | ||
|
|
||
| fn handle_existing_chatgpt_login(&mut self) -> bool { |
Collaborator
There was a problem hiding this comment.
nit: A bool return value isn't really all that useful without documenting its meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously device code replaces the standard "Sign in with ChatGPT" option when headless environment is detected. This prevents certain users who's normal dev setup is remote devboxes. So we are move it to be an additional option alongside the standard browser flow instead of replacing it.