fix: send non-null content on elicitation Accept#9196
Merged
bolinfest merged 1 commit intoopenai:mainfrom Jan 15, 2026
Merged
Conversation
Collaborator
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
4b4e3a9 to
c7272ff
Compare
When a user accepts an MCP elicitation request, send `content: Some(json!({}))`
instead of `None`. MCP servers that use elicitation expect content to be
present when action is Accept.
Fixes openai#9053
c7ffdda to
ea20360
Compare
bolinfest
reviewed
Jan 15, 2026
| // When accepting, send an empty object as content to satisfy MCP servers | ||
| // that expect non-null content on Accept. For Decline/Cancel, content is None. | ||
| let content = match action { | ||
| ElicitationAction::Accept => Some(serde_json::json!({})), |
Collaborator
There was a problem hiding this comment.
Seems reasonable.
FYI, I did some related work on the MCP Inspector: modelcontextprotocol/inspector#926.
bolinfest
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
content: Some(json!({}))instead ofNoneexec-server/tests/common/lib.rs:171Root Cause
In
codex-rs/core/src/codex.rs, theresolve_elicitationfunction always sentcontent: None:Fix
Send an empty object when accepting:
Test plan
cargo check -p codex-corejust fmtaccept_elicitation_for_prompt_rule(requires MCP server binary)Fixes #9053