Merged
Conversation
Use review_model from config only when present, otherwise fall back to the session/client model for review threads and sub‑agents. Fix otel manager model wiring and update tests to cover both custom and unset review_model cases.
|
|
||
| let mut config = self.config.as_ref().clone(); | ||
| config.model = Some(self.config.review_model.clone()); | ||
| if let Some(review_model) = &config.review_model { |
Collaborator
There was a problem hiding this comment.
is there a difference between self.config and config?
Collaborator
Author
There was a problem hiding this comment.
config = self.config.as_ref().clone(); ?
Collaborator
There was a problem hiding this comment.
yeah was just wondering why are we using self a line above it.
|
|
||
| // Build per‑turn client with the requested model/family. | ||
| let mut per_turn_config = (*config).clone(); | ||
| per_turn_config.model_reasoning_effort = Some(ReasoningEffortConfig::Low); |
Collaborator
Author
There was a problem hiding this comment.
Related, I'd like to use the current reasoning effort as well.
aibrahim-oai
approved these changes
Jan 14, 2026
Collaborator
|
Please make sure that any behavior changes here are also reflected in the VSCE, which also implements a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having a hard-coded default review model, use the current model for running
/reviewunless one is specified in the config.Also inherit current reasoning effort