Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/core/src/unified_exec/process_manager.rs
Lines 206 to 210 in db3835e
Preserve waiting status events for non-TUI clients
Removing the waiting-status emission here means long‑lived unified exec sessions no longer produce BackgroundEvent notifications. The new waiting UI is driven by TerminalInteractionEvent in tui, but tui2 still leaves on_terminal_interaction as TODO and the exec CLI ignores EventMsg::TerminalInteraction while only printing BackgroundEvent (see codex-rs/tui2/src/chatwidget.rs and codex-rs/exec/src/event_processor_with_human_output.rs). As a result, when a background terminal is waiting (empty‑stdin polls), those clients never surface any “waiting” feedback. Consider keeping the background event (or emitting an alternative status update) for non‑TUI consumers.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| session | ||
| .send_event( | ||
| turn.as_ref(), | ||
| EventMsg::BackgroundEvent(BackgroundEventEvent { message }), | ||
| ) | ||
| .await; |
There was a problem hiding this comment.
do we want to update the app/VSCE and web?
There was a problem hiding this comment.
Yep probably, it's why I pinged you
There was a problem hiding this comment.
For VSCE and app we do not use this for any rendering yet.
There was a problem hiding this comment.
Let's come up with something, I bet we want to use it at some point.
shijie-oai
left a comment
shijie-oai
left a comment
There was a problem hiding this comment.
LGTM from VCSE/app side.
# Conflicts: # codex-rs/tui/src/chatwidget.rs
3 participants
No description provided.