Support response.done and add integration tests#9129
Merged
pakrym-oai merged 11 commits intomainfrom Jan 13, 2026
Merged
Conversation
Add clippy allowance for large ResponsesWsRequest enum and simplify JSON encoding error handling. Extract websocket_append_items helper in ModelClientSession to clarify append behavior. Refactor websocket tests to use helper constructors for prompts and message items.
…sponse-done-and-add-integration-tests
aibrahim-oai
approved these changes
Jan 13, 2026
Rename websocket_append_items() to get_incremental_items() and add comments explaining when a response.append request is issued vs starting a new response.create request.
…sponse-done-and-add-integration-tests
pakrym-oai
deleted the
pakrym/support-response-done-and-add-integration-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent loop using a persistent incremental web socket connection.