Merged
Conversation
Add TODO on websocket idle timeout placement, fix whitespace and line wrapping in websocket client/session, and allow expect/unwrap in websocket tests.
- Inline websocket connection into ModelClientSession and drop WebsocketSessionState - Correct connection reuse condition to only reconnect when closed - Handle missing connection with explicit ApiError - Update websocket tests: apply crate-level clippy allow and skip when no network
| self.build_responses_websocket_request(&api_provider, &api_prompt, options)?; | ||
|
|
||
| let connection = match self | ||
| .websocket_connection( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuses the connection but still sends full requests.