Skip to content

fix: reduce duplicate include_str!() calls#8914

Merged
bolinfest merged 1 commit intomainfrom
pr8914
Jan 8, 2026
Merged

fix: reduce duplicate include_str!() calls#8914
bolinfest merged 1 commit intomainfrom
pr8914

Conversation

@bolinfest
Copy link
Collaborator

@bolinfest bolinfest commented Jan 8, 2026

This will help with the Bazel build, but it also means fewer copies of large strings in test binaries.

include_str!("../../../apply-patch/apply_patch_tool_instructions.md"),
]
.join("\n");
let expected_instructions = [BASE_INSTRUCTIONS, APPLY_PATCH_TOOL_INSTRUCTIONS].join("\n");
Copy link
Contributor

@zbarsky-openai zbarsky-openai Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice, maybe we can remove one of the compile_data directives now

@bolinfest bolinfest merged commit 59d6937 into main Jan 8, 2026
63 of 68 checks passed
@bolinfest bolinfest deleted the pr8914 branch January 8, 2026 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants