perf(tui2): reduce unnecessary redraws#8681
Merged
joshka-oai merged 2 commits intomainfrom Jan 2, 2026
Merged
Conversation
During streaming, agent deltas can arrive at very high frequency. Scheduling a redraw for every delta drives a near-constant render loop (clamped by FrameRequester) even when newline-gated streaming hasn't produced any new visible transcript lines yet. Only schedule a redraw for deltas that cause an immediate visible change (e.g. flushing an active cell group or inserting the final-message separator). Otherwise, rely on commit ticks to request redraws when a committed history cell is actually appended.
App publishes derived transcript viewport state to the footer after every draw. BottomPane was unconditionally scheduling another frame when receiving that state, even when nothing changed. This created a self-sustaining redraw loop (clamped by FrameRequester) and burned CPU while visually idle. Only request a redraw when the derived transcript UI state (scrolled/selection/position/copy key) actually changes.
aibrahim-oai
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces unnecessary frame scheduling in codex-tui2.
Changes:
Why:
Testing:
Manual sampling: