UI tweaks on skills popup. #8250
Conversation
xl-openai
force-pushed
the
xl/skills-ui
branch
3 times, most recently
from
d262170 to
de2f176
Compare
|
@codex review again |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let wrapped = word_wrap_lines([full_line.clone()], options); | ||
| let max_row_lines = row.max_row_lines.unwrap_or(usize::MAX); | ||
| let wrapped = if wrapped.len() > max_row_lines { | ||
| let mut limited: Vec<Line<'static>> = wrapped.into_iter().take(max_row_lines).collect(); | ||
| if let Some(last) = limited.pop() { |
There was a problem hiding this comment.
The new max_row_lines truncation is only applied during rendering; measure_rows_height still counts all wrapped lines. Because SkillPopup::calculate_required_height uses measure_rows_height, the popup can still reserve vertical space for the full description even though rendering is capped at two lines, so the change doesn’t actually prevent the popup from growing tall and can leave large empty space / shrink other panes. Consider applying the same max_row_lines cap (and ellipsis logic if needed) inside measure_rows_height so sizing matches rendering. The same mismatch exists in tui2’s selection_popup_common.rs.
Useful? React with 👍 / 👎.
xl-openai
force-pushed
the
xl/skills-ui
branch
2 times, most recently
from
687a434 to
ad79d5e
Compare
|
@codex review again |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
xl-openai
force-pushed
the
xl/skills-ui
branch
3 times, most recently
from
7201434 to
63c3838
Compare
xl-openai
force-pushed
the
xl/skills-ui
branch
from
63c3838 to
2feb84d
Compare
xl-openai
force-pushed
the
xl/skills-ui
branch
from
2feb84d to
366e20d
Compare
Only display the skill name (not the folder), and truncate the skill description to a maximum of two lines.