[release] Add a dmg target for MacOS #8207
Merged
+166
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celia-oai
force-pushed
the
dev/cc/dmg
branch
3 times, most recently
from
a4d34a9 to
2c21acd
Compare
celia-oai
force-pushed
the
dev/cc/dmg
branch
from
2c21acd to
b633cfb
Compare
shijie-oai
reviewed
Dec 17, 2025
Collaborator
|
@codex review |
shijie-oai
approved these changes
Dec 17, 2025
Collaborator
shijie-oai
left a comment
shijie-oai
left a comment
There was a problem hiding this comment.
First pass and LGTM - left a small comment and can re-review it after the changes.
Contributor
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
celia-oai
force-pushed
the
dev/cc/dmg
branch
from
d0ab81c to
39b24b7
Compare
JaviSoto
reviewed
Dec 18, 2025
celia-oai
force-pushed
the
dev/cc/dmg
branch
2 times, most recently
from
cfb45ad to
1fe223f
Compare
celia-oai
force-pushed
the
dev/cc/dmg
branch
from
1fe223f to
786cde9
Compare
celia-oai
force-pushed
the
dev/cc/dmg
branch
from
e6b87c3 to
c55b89e
Compare
JaviSoto
reviewed
Dec 18, 2025
Contributor
JaviSoto
left a comment
JaviSoto
left a comment
There was a problem hiding this comment.
It looks great thank you!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dmg target that bundles the codex and codex responses api proxy binaries for MacOS. this target is signed and notarized.
Verified by triggering a build here: https://github.com/openai/codex/actions/runs/20318136302/job/58367155205. Downloaded the artifact and verified that the dmg is signed and notarized, and the codex binary contained works as expected.