Load models from static file #8153
Merged
+606
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Dec 17, 2025
pakrym-oai
reviewed
Dec 17, 2025
| pub async fn refresh_available_models(&self, config: &Config) -> CoreResult<()> { | ||
| if !config.features.enabled(Feature::RemoteModels) { | ||
| if !config.features.enabled(Feature::RemoteModels) | ||
| || self.auth_manager.get_auth_mode() == Some(AuthMode::ApiKey) |
Collaborator
There was a problem hiding this comment.
Should we test the change first behind the feature?
Collaborator
Author
There was a problem hiding this comment.
I'd say let's get more feedback
pakrym-oai
reviewed
Dec 17, 2025
| } | ||
|
|
||
| #[test] | ||
| fn bundled_models_json_roundtrips() { |
Collaborator
There was a problem hiding this comment.
check that it actually roundtrips, deserialize/serialize check the same content. You'll catch fields that we missed that way.
pakrym-oai
approved these changes
Dec 17, 2025
…o static-fallback
…o static-fallback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.