Add a workflow for a hardcoded version of models #8118
Conversation
|
@codex review this |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let token = require_openai_api_key()?; | ||
|
|
||
| let provider = ModelProviderInfo::create_openai_provider(); | ||
| let api_provider = provider.to_api_provider(Some(AuthMode::ChatGPT))?; |
There was a problem hiding this comment.
This binary always reads OPENAI_API_KEY but then forces AuthMode::ChatGPT, which makes to_api_provider target the ChatGPT backend (https://chatgpt.com/backend-api/codex). Standard OpenAI API keys are not accepted there, so the workflow (which exports OPENAI_API_KEY) will consistently 401 and never update models.json unless the secret is actually a ChatGPT access token. Consider defaulting to the API-key auth mode (or making the auth mode configurable) when you’re using OPENAI_API_KEY.
Useful? React with 👍 / 👎.
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
|
@codex review this |
| ) | ||
|
|
||
| url="${base_url%/}/models?client_version=${client_version}" | ||
| curl --fail --show-error --location "${headers[@]}" "${url}" | jq '.' > codex-rs/core/models.json |
There was a problem hiding this comment.
will this leak the key?
There was a problem hiding this comment.
no this doesn't print the headers supposedly
| @@ -0,0 +1,48 @@ | |||
| name: rust-release-prepare | |||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
should this run on schedule?
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Uh oh!
There was an error while loading. Please reload this page.