Skip to content

Conversation

@dylan-hurd-oai
Copy link
Collaborator

@dylan-hurd-oai dylan-hurd-oai commented Dec 16, 2025

Summary:

This PR is a pure copy and paste of tests from lib.rs into invocation.rs, to colocate logic and tests.

Testing

  • Purely a test refactor

@dylan-hurd-oai dylan-hurd-oai changed the base branch from main to pr8110 December 16, 2025 17:40
dylan-hurd-oai added a commit that referenced this pull request Dec 16, 2025
lib.rs has grown quite large, and mixes two responsibilities:
1. executing patch operations
2. parsing apply_patch invocations via a shell command

This PR splits out (2) into its own file, so we can work with it more
easily. We are explicitly NOT moving tests in this PR, to ensure
behavior stays the same and we can avoid losing coverage via merge
conflicts. Tests are moved in a subsequent PR.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/8110).
* #8111
* __->__ #8110
Base automatically changed from pr8110 to main December 16, 2025 18:31
## Summary:
This PR is a pure copy and paste of tests from lib.rs into invocation.rs, to colocate logic and tests.

## Testing
- [x] Purely a test refactor
@dylan-hurd-oai dylan-hurd-oai merged commit a3b137d into main Dec 16, 2025
50 of 52 checks passed
@dylan-hurd-oai dylan-hurd-oai deleted the pr8111 branch December 16, 2025 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants