Fixes mcp elicitation test that fails for me when run locally #8020
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
approved these changes
Dec 15, 2025
| use crate::util::try_parse_error_message; | ||
| use codex_client::CodexHttpClient; | ||
| use codex_protocol::account::PlanType as AccountPlanType; | ||
| #[cfg(any(test, feature = "test-support"))] |
Collaborator
There was a problem hiding this comment.
Should these be part of this PR? Seems unrelated.
Collaborator
Author
There was a problem hiding this comment.
I ran into this lint when debugging the problem. I could move it to a separate PR, but it seemed small enough to just include here.
Comment on lines
58
to
68
| let git = Command::new("bash") | ||
| .arg("-lc") | ||
| .arg("command -v git") | ||
| .output() | ||
| .await | ||
| .context("failed to resolve git via login shell")?; | ||
| let git_path = String::from_utf8(git.stdout) | ||
| .context("git path was not valid utf8")? | ||
| .trim() | ||
| .to_string(); | ||
| ensure!(!git_path.is_empty(), "git path should not be empty"); |
Collaborator
There was a problem hiding this comment.
Thanks for figuring out this fix!
Do you mind moving it to a helper function? I try to minimize the "extra scaffolding" in an integration test so it feels more like executable documentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.