Fix: Skip Option<()> schema generation to avoid invalid Windows filenames (#7479) #7969
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…invalid Windows filenames The schema generation process attempts to create Option<()>.json files, which fail on Windows due to invalid filename characters. This change extends the existing IGNORED_DEFINITIONS constant to also skip Option<()> when generating individual JSON schema files, maintaining consistency with bundle generation behavior. Resolves Windows filename error for codex app-server generate-json-schema
Contributor
Author
|
Hi @etraut-openai any updates for this PR |
Collaborator
|
@448523760, it looks good to me, but I'd like to have another member of the codex team review it as well. It's in the queue. |
owenlin0
approved these changes
Dec 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When generating JSON schemas on Windows, the
codex app-server generate-json-schemacommand fails with a filename error:This occurs because Windows doesn't allow certain characters in filenames, specifically the angle brackets <> used in the Option<()> type name.
Root Cause
The schema generation process attempts to create individual JSON files for each schema definition, including
Option<()>. However, the characters<and>are invalid in Windows filenames, causing the file creation to fail.Solution
The fix extends the existing
IGNORED_DEFINITIONSconstant (which was already being used in the bundle generation) to also skipOption<()>when generating individual JSON schema files. This maintains consistency with the existing behavior whereOption<()>is excluded from the bundled schema.close #7479