Make migration screen dynamic #7896
Conversation
|
@codex review this |
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review this |
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| /// Toggle the model migration prompt acknowledgement flag. | ||
| SetNoticeHideModelMigrationPrompt(String, bool), | ||
| /// Record that a migration prompt was shown for an old->new model mapping. | ||
| RecordModelMigrationSeen { from: String, to: String }, |
There was a problem hiding this comment.
I think it's easier to reason about from the ModelPreset pov. I don't have strong opinion though.
|
@codex review this |
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review this |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
left a comment
sayan-oai
left a comment
There was a problem hiding this comment.
One question, otherwise lgtm
| Some(preset.description.clone()) | ||
| } | ||
| }); | ||
| let can_opt_out = current_preset.is_some(); |
There was a problem hiding this comment.
I think can_opt_out is always true here because we are in the path where an upgrade was found, so current_preset is always Some. Is this intended?
There was a problem hiding this comment.
Yes, a follow up on that would be to get this dynamically from the server.
External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.
Include a link to a bug report or enhancement request.