feat: introduce utilities for locating pwsh.exe and powershell.exe #7893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
requested review from
dylan-hurd-oai,
iceweasel-oai and
pakrym-oai
bolinfest
force-pushed
the
pr7893
branch
3 times, most recently
from
6bb3bc3 to
4925c8d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to tighten up some of our logic around PowerShell over in #7607 and it would be helpful to be more precise about
pwsh.exeversuspowershell.exe, as they do not accept the exact same input language.To that end, this PR introduces utilities for detecting each on the system. I think we also want to update
get_user_shell_path()to return PowerShell instead ofNoneon Windows, but we'll consider that in a separate PR since it may require more testing.