Update Model Info #7853
Update Model Info #7853
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.supports_reasoning_summaries = supports_reasoning_summaries; | ||
| self.support_verbosity = support_verbosity; | ||
| self.default_verbosity = default_verbosity; | ||
| self.apply_patch_tool_type = apply_patch_tool_type; |
There was a problem hiding this comment.
The new apply_remote_overrides now assigns supports_reasoning_summaries, support_verbosity, default_verbosity, and other new metadata directly from the server response. Because the added fields in ModelInfo use #[serde(default)], a backend that hasn’t been updated to return these keys will deserialize them as false/None and this block will overwrite the local per-family defaults (e.g., gpt-5.1’s verbosity/reasoning flags) with those defaults, effectively disabling supported features and altering truncation/patch behavior. The previous implementation preserved local defaults when the remote payload lacked a field; this change regresses that compatibility for any deployment still serving the older /models schema.
Useful? React with 👍 / 👎.
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No description provided.