Restore status header after stream recovery #7660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka-oai
force-pushed
the
codex/fix-sticky-reconnecting-banner
branch
3 times, most recently
from
9a592af to
894e252
Compare
Collaborator
dylan-hurd-oai
left a comment
dylan-hurd-oai
left a comment
There was a problem hiding this comment.
LGTM once we remove the CI changes
| let is_stream_error = matches!(&msg, EventMsg::StreamError(_)); | ||
| if !is_stream_error { | ||
| self.restore_retry_status_header_if_present(); | ||
| } |
Collaborator
There was a problem hiding this comment.
are there other error cases where we might want to do this?
Collaborator
Author
There was a problem hiding this comment.
There's a possibility that some other path in App::handle_event() might need this. I don't know that code well, so I'd defer that unless we need it for now.
joshka-oai
force-pushed
the
codex/fix-sticky-reconnecting-banner
branch
from
446f66c to
894e252
Compare
joshka-oai
force-pushed
the
codex/fix-sticky-reconnecting-banner
branch
from
894e252 to
cf3e860
Compare
dylan-hurd-oai
approved these changes
Dec 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task