Also load skills from repo root. #7645
Merged
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voctory
reviewed
Dec 5, 2025
codex-rs/core/src/skills/loader.rs
Outdated
|
|
||
| const SKILLS_FILENAME: &str = "SKILL.md"; | ||
| const SKILLS_DIR_NAME: &str = "skills"; | ||
| const SKILLS_REPO_DIR_NAME: &str = "codex"; |
Contributor
There was a problem hiding this comment.
Should this be .codex instead of codex? To be consistent with the global .codex directory and other conventions for SKILL.md files (since they're not first-class project files)
Contributor
There was a problem hiding this comment.
+1. On naming, this is either a REPO_ROOT_CONFIG_DIR_NAME or just CONFIG_DIR_NAME and value should be .codex. We're effectively reading from $repo_root/.codex/skills.
gverma-openai
approved these changes
Dec 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also load skills from /REPO_ROOT/codex/skills.