Skip to content

Add vim navigation keys to transcript pager #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshka-oai merged 1 commit into from
Dec 9, 2025
Merged

Add vim navigation keys to transcript pager #7550

joshka-oai merged 1 commit into from
Dec 9, 2025

Conversation

@joshka-oai
Copy link
Collaborator

@joshka-oai joshka-oai commented Dec 3, 2025 •
edited
Loading

Summary

  • add vim-style pager navigation for transcript overlays (j/k, ctrl+f/b/d/u) without removing existing keys
  • add shift-space to page up

Codex Task

@joshka-oai joshka-oai requested a review from aw-oai December 3, 2025 22:25
@joshka-oai
Copy link
Collaborator Author

joshka-oai commented Dec 3, 2025

Not sure where the RUSTFLAGS tests instructions are coming from above

Tested that this works locally.

Testing this highlights a bug that the paging in transcript is incorrect (it skips 3 rows because it's not factoring in the header and footer).

@joshka-oai
Copy link
Collaborator Author

joshka-oai commented Dec 3, 2025

image

aw-oai
aw-oai approved these changes Dec 3, 2025
View reviewed changes
Copy link

@aw-oai aw-oai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay ty.

some random thoughts:

i do feel like adding the instructions there make it too busy and isn't necessary. every vim user will just try to use those keys instinctively upon seeing a pager interface, and it's maybe uncommon enough to pollute that section.

also for a standard key equivalent for half-page, maybe <space> and shift+<space>.

@joshka-oai
Copy link
Collaborator Author

joshka-oai commented Dec 3, 2025

i do feel like adding the instructions there make it too busy and isn't necessary. every vim user will just try to use those keys instinctively upon seeing a pager interface, and it's maybe uncommon enough to pollute that section.

I agree (I was 60/40 on it, so left it as is). Good to get some external confirmation - will fix.

also for a standard key equivalent for half-page, maybe and shift+.

We map space to full page down. Shift space makes sense to do full page up. Is there a reason for half page?

aw-oai
aw-oai approved these changes Dec 4, 2025
View reviewed changes
Copy link

@aw-oai aw-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We map space to full page down. Shift space makes sense to do full page up. Is there a reason for half page?

Ah okay. Nah I just didn't see any instructions in your screenshot for the half-page other than the vim binding, so was throwing a suggestion in case there wasn't a non-vim binding.

Thanks again

@joshka-oai
Copy link
Collaborator Author

joshka-oai commented Dec 9, 2025

@codex fix the tests

@joshka-oai joshka-oai mentioned this pull request Dec 9, 2025
Merged
@joshka-oai joshka-oai force-pushed the codex/add-vim-key-binds-to-transcript-overlay branch from f6d6b59 to d2a5622 Compare December 9, 2025 01:57
@chatgpt-codex-connector
Copy link
Contributor

chatgpt-codex-connector bot commented Dec 9, 2025

Summary

  • Adjusted pager navigation to base page and half-page jumps on the rendered content height so transcript paging no longer skips lines when header/footer space is present (tui/src/pager_overlay.rs).
  • Factored scroll-key handling into reusable helpers and added a regression test confirming pager navigation respects the visible content area.

Testing

  • ✅ just fmt
  • ⚠️ just fix -p codex-tui (fails: tokio test-util functions like time::advance/start_paused are unavailable in this build even with --cfg tokio_unstable)
  • ⚠️ RUSTFLAGS="--cfg tokio_unstable" cargo test -p codex-tui (fails: tokio test-util functions like time::advance/start_paused are unavailable in this build)

View task →

@joshka-oai
Add vim navigation keys to transcript pager
612157c 
- Ctrl+F / Ctrl+B for page down/up
- Ctrl+D / Ctrl+U for half page down/up
- Shift+Space for half page up
@joshka-oai joshka-oai force-pushed the codex/add-vim-key-binds-to-transcript-overlay branch from d2a5622 to 612157c Compare December 9, 2025 02:54
@joshka-oai joshka-oai merged commit 9df70a0 into main Dec 9, 2025
26 checks passed
@joshka-oai joshka-oai deleted the codex/add-vim-key-binds-to-transcript-overlay branch December 9, 2025 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@easong-openai easong-openai easong-openai approved these changes

@aw-oai aw-oai aw-oai approved these changes

@nornagon-openai nornagon-openai Awaiting requested review from nornagon-openai

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshka-oai @easong-openai @aw-oai