Use shared check sandboxing #7547
Merged
+46
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move sandbox denial detection into UnifiedExecSession by introducing check_for_sandbox_denial_with_text() and calling it from check_for_sandbox_denial(). Remove the session_manager::sandboxing module and update call sites to use the new helper and existing exit code.
jif-oai
approved these changes
Dec 4, 2025
| process_id: if has_exited { | ||
| None | ||
| } else { | ||
| Some(request.process_id.clone()) |
Collaborator
There was a problem hiding this comment.
Why not re-using process_id?
Collaborator
Author
There was a problem hiding this comment.
It's moved in one of the branches above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.