execpolicy tui flow #7543
Merged
execpolicy tui flow #7543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
from
91c54fc to
878ae52
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
3 times, most recently
from
638128c to
00d6382
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
2 times, most recently
from
cde8d54 to
8070a09
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
from
00d6382 to
505b845
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
from
8070a09 to
9612eba
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
3 times, most recently
from
d49a447 to
01a8814
Compare
bolinfest
approved these changes
Dec 4, 2025
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
from
9612eba to
2c204a1
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
2 times, most recently
from
1cc4c2d to
27804c3
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
3 times, most recently
from
f8f7e88 to
5ff39c5
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-refactor
branch
from
c12dd09 to
4488061
Compare
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
from
356be2c to
18e89c4
Compare
Add explicit prefix-approval decision and wire it through execpolicy/UI snapshots update doc mutating in memory policy instead of reloading using RW locks clippy refactor: adding allow_prefix into ApprovedAllowPrefix fmt do not send allow_prefix if execpolicy is disabled moving args around cleanup exec_policy getters undo diff fixing rw lock bug causing tui to hang updating phrasing integration test . fix compile fix flaky test fix compile error running test with single thread fixup allow_prefix_if_applicable fix formatting fix approvals test only cloning when needed docs add docstring fix rebase bug fixing rebase issues Revert "fixing rebase issues" This reverts commit 79ce7e1. fix rebase errors
zhao-oai
force-pushed
the
dev/zhao/execpolicy-tui-flow
branch
from
18e89c4 to
ef9c195
Compare
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
execpolicyTUI flowIn the TUI, when going through the command approval flow, codex will now ask the user if they would like to whitelist the FIRST unmatched command among a chain of commands.
For example, let's say the agent wants to run
apple | pearwith an emptyexecpolicyNeither apple nor pear will match to an
execpolicyrule. Thus, when prompting the user, codex tui will ask the user if they would like to whitelistapple.If the agent wants to run
apple | pearagain, they would be prompted again because pear is still unknown. when prompted, the user will now be asked if they'd like to whitelistpear.Here's a demo video of this flow:
new_whitelist_flow.mov
This PR also removed the
allow for this sessionoption from the TUI.