tmp: drop sccache for windows #6673
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Speed up repeated builds across CI runs by caching compiled objects (non-Windows). | ||
| USE_SCCACHE: ${{ startsWith(matrix.runner, 'windows') && 'false' || 'true' }} | ||
| RUSTC_WRAPPER: ${{ startsWith(matrix.runner, 'windows') && '' || 'sccache' }} | ||
| CARGO_INCREMENTAL: "0" |
There was a problem hiding this comment.
The new env block sets RUSTC_WRAPPER: ${{ startsWith(matrix.runner, 'windows') && '' || 'sccache' }} (and the same block is duplicated for the test job). On Windows runners startsWith evaluates to true, so RUSTC_WRAPPER is exported as an empty string. Cargo only checks whether RUSTC_WRAPPER is present, not whether it is non-empty, so every cargo invocation on Windows will now try to execute a program whose path is "" and immediately fail with “failed to execute: No such file or directory,” breaking all Windows CI jobs. To actually “drop sccache for Windows” you need to omit the variable entirely for Windows rather than setting it to an empty string.
Useful? React with 👍 / 👎.
No description provided.