chore(core) Consolidate apply_patch tests #6545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-hurd-oai
commented
Nov 12, 2025
| | ApplyPatchModelOutput::Shell | ||
| | ApplyPatchModelOutput::ShellViaHeredoc => self.function_call_stdout(call_id).await, | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I know it's not ideal to expand the scope of the harness, but this felt significantly simpler than introducing async function type signatures / closures in the apply_patch test suite
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dylan-hurd-oai
force-pushed
the
dh--refactor-apply-patch-tests
branch
from
60360dc to
893822e
Compare
dylan-hurd-oai
force-pushed
the
dh--refactor-apply-patch-tests
branch
2 times, most recently
from
bfa73b2 to
0e3cf67
Compare
pakrym-oai
reviewed
Nov 13, 2025
pakrym-oai
reviewed
Nov 13, 2025
pakrym-oai
reviewed
Nov 13, 2025
pakrym-oai
approved these changes
Nov 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates our apply_patch tests into one suite, and ensures each test case tests the various ways the harness supports apply_patch:
There are a few test cases that are specific to a particular variant, I've left those alone.
Testing