feat: better UI for unified_exec #6515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
reviewed
Nov 12, 2025
| vec!["bash".into(), "-lc".into(), "ls".into()], | ||
| vec![ParsedCommand::Unknown { cmd: "ls".into() }], | ||
| false, | ||
| ExecCommandSource::Agent, |
Collaborator
There was a problem hiding this comment.
will this break VSCode? do they consume this property?
Collaborator
Author
There was a problem hiding this comment.
Checking with the team
pakrym-oai
approved these changes
Nov 12, 2025
zhao-oai
reviewed
Nov 13, 2025
| /// Where the command originated. Defaults to Agent for backward compatibility. | ||
| #[serde(default)] | ||
| pub is_user_shell_command: bool, | ||
| pub source: ExecCommandSource, |
Contributor
There was a problem hiding this comment.
wanted to flag that we'll need to update the app-server protocol for VsCode after this change gets in
# Conflicts: # codex-rs/core/src/tools/events.rs # codex-rs/core/src/tools/handlers/shell.rs # codex-rs/core/src/tools/handlers/unified_exec.rs # codex-rs/core/src/unified_exec/session_manager.rs # codex-rs/core/tests/suite/unified_exec.rs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.