Conversation
Codex thought this was a good idea while working on #10192.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b82d1c3e2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| impl std::ops::Mul<f64> for TruncationPolicy { | ||
| type Output = Self; | ||
|
|
||
| fn mul(self, multiplier: f64) -> Self::Output { |
There was a problem hiding this comment.
Implementing Mul<f64> is fine for operator use, but removing the inherent TruncationPolicy::mul is a breaking API change: callers using policy.mul(1.2) (without use std::ops::Mul;) will now fail to compile. Mul is not in the prelude, so the method is no longer available by default. If this type is part of the public API, consider keeping an inherent mul that delegates to self * multiplier to preserve downstream compatibility.
Useful? React with 👍 / 👎.
2 participants
Codex thought this was a good idea while working on #10192.