chore: deprecate old web search feature flags#10097
Merged
Conversation
slightly rework legacy_usages to enable pointing to non-features from deprecated features
pakrym-oai
reviewed
Jan 28, 2026
| } | ||
| } | ||
|
|
||
| fn legacy_usage_notice(alias: &str, feature: Feature) -> (String, Option<String>) { |
Collaborator
There was a problem hiding this comment.
I don't know how I feel about rendering inside core but this logic has to be somewhere.
Collaborator
Author
There was a problem hiding this comment.
yea, we emit from core. i think having it next to the rest of the logic is nicer than hiding it in another module for now.
pakrym-oai
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deprecate all old web search flags and aliases, including:
[features].web_search_requestand[features].web_search_cached[tools].web_search[features].web_searchslightly rework
legacy_usagesto enable pointing to non-features from deprecated features; we need to point toweb_search(not under[features]) from things like[features].web_search_cachedand[features].web_search_request.Added integration tests to confirm deprecation notice is shown on explicit enablement and disablement of deprecated flags.