Skip to content

Play metadata update and disable controller spans by default #15604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trask merged 5 commits into from
Dec 11, 2025
Merged

Play metadata update and disable controller spans by default #15604

trask merged 5 commits into from
Dec 11, 2025

Conversation

@jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Dec 11, 2025 •
edited
Loading

Part of #14096

Also noticed that 2.6 was creating controller spans without checking the configuration option, so I changed that. I can move it to a separate PR if we want, otherwise I can slap the "breaking change" label on here.

Migration notes

Controller spans emitted by Play MVC 2.6 instrumentation are now disabled by default, but can be re-enabled with the configuration option: otel.instrumentation.common.experimental.controller-telemetry.enabled=true.

@jaydeluca jaydeluca requested a review from a team as a code owner December 11, 2025 11:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

⚠️ Breaking Change Documentation Required

This PR has been labeled as a breaking change. Please ensure you provide the following information:

Migration Notes Required

Please add detailed migration notes to help users understand:

  • What is changing and why
  • How to update their code/configuration
  • Any alternative approaches if applicable
  • Code examples showing before/after usage

Checklist

  • Migration notes added to the PR description
  • Breaking change is documented in the "Unreleased" section of the Changelog, preferably as part of this PR.
  • Consider if this change requires a major version bump

Your migration notes will be included in the release notes to help users upgrade smoothly. The more detailed and helpful they are, the better the user experience will be.

This comment was automatically generated because the breaking change label was applied to this PR.

@trask trask merged commit 2e9cf2b into open-telemetry:main Dec 11, 2025
88 checks passed
@jaydeluca jaydeluca mentioned this pull request Dec 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaydeluca @laurit @trask