Skip to content

feat: support custom ClientResources in lettuce framework #15470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trask merged 8 commits into from
Dec 5, 2025
Merged

feat: support custom ClientResources in lettuce framework #15470

trask merged 8 commits into from
Dec 5, 2025
+12 −6

Conversation

@123liuziming
Copy link
Contributor

@123liuziming 123liuziming commented Nov 27, 2025 •
edited
Loading

@123liuziming 123liuziming requested a review from a team as a code owner November 27, 2025 05:42
@123liuziming 123liuziming mentioned this pull request Nov 27, 2025
Open
@123liuziming
Copy link
Contributor Author

123liuziming commented Nov 27, 2025

image Seems that I do not modify the spring-kafka related files.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 3, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Dec 3, 2025
@123liuziming 123liuziming force-pushed the feat/custom-client-resources branch from 24dd9dd to 66be37b Compare December 3, 2025 12:31
@123liuziming
chore: resolve conflict
0cf9117 
Change-Id: I4616ea3486ccdd74f41ce4a26c6dc828e04d2a99
@123liuziming
chore: apply spotless check
9b819af 
Change-Id: I8220b7890eecafa9cff27253dcb8ef1eb3d1b231
@123liuziming
chore: try to add custom client resource
ea07470 
Change-Id: I8db51ffb0b9d7e0cd5cd4b88c83105b6ee3aa850
@123liuziming
chore: add final decorator
e395763 
Change-Id: Ia30514646ce3041e4a89b1b77463581c682427d5
@123liuziming
chore: apply spotless
b476c11 
Change-Id: I5402c2d51c1a6f05e5e7c3e2435a122cd200d462
@123liuziming
chore: apply spotless
6c92c64 
Change-Id: I07b6f5902c534d220e0f1b182583f96ac727dc44
@123liuziming 123liuziming force-pushed the feat/custom-client-resources branch from 66be37b to 6c92c64 Compare December 3, 2025 12:36
@123liuziming
chore: remove redundant test
fc85a6f 
Change-Id: Ic8fde24648604685979699dbca1f93da382b341b
@123liuziming
chore: remove redundant test
52218e6 
Change-Id: I82f2148dcb4f8837b053b27dc3b8953399bb8252
@laurit
Copy link
Contributor

laurit commented Dec 4, 2025

@123liuziming do you have code that depends on this? Do you implement ClientResources yourself without using DefaultClientResources?

@123liuziming
Copy link
Contributor Author

123liuziming commented Dec 4, 2025

@123liuziming do you have code that depends on this? Do you implement ClientResources yourself without using DefaultClientResources?

Yes, some of our customers implement their own ClientResources. In such cases, no telemetry data of lettuce will be collected.

@laurit laurit added this to the v2.23.0 milestone Dec 4, 2025
@trask trask merged commit 30f4761 into open-telemetry:main Dec 5, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

Assignees

No one assigned

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Milestone

v2.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@123liuziming @laurit @trask