Emit schema url from HTTP instrumentations #15144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Oct 25, 2025
...try/instrumentation/api/incubator/builder/internal/DefaultHttpClientInstrumenterBuilder.java
Show resolved
Hide resolved
20 tasks
The test framework was not copying the schema URL from the protobuf ScopeSpans to the InstrumentationScopeInfo when converting spans, causing all schema URL assertions to fail even though spans were correctly emitting schema URLs.
The instrumenterBuilder() method in DefaultHttpClientInstrumenterBuilder was creating new Instrumenter builders without setting the schema URL. This affected connection-level instrumentations (e.g., Netty connection spans for error cases) which use this method to create their instrumenters. Fixes failing tests in finagle-http-23.11 where connection error spans were missing the schema URL.
The TelemetryConverter now correctly preserves schema URLs from protobuf data. The MeterTest files create meters with schema URL 'http://schema.org', so the test expectations need to be updated to match.
zeitlinger
approved these changes
Nov 4, 2025
laurit
reviewed
Nov 4, 2025
| .addAttributesExtractors(additionalExtractors) | ||
| .addOperationMetrics(HttpClientMetrics.get()); | ||
| .addOperationMetrics(HttpClientMetrics.get()) | ||
| .setSchemaUrl(SchemaUrls.V1_37_0); |
Contributor
There was a problem hiding this comment.
does setting schema url pose any additional restrictions to what we can do with these instrumentations?
Member
Author
There was a problem hiding this comment.
we can still emit additional attributes if that what you're asking?
laurit
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12846