Skip to content

Make LambdaInstance release dead sandbox when it OOMs #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darkryder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make LambdaInstance release dead sandbox when it OOMs #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion go/worker/lambda/lambdaInstance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package lambda

import (
"errors"
"fmt"
"io"
"log/slog"
"net/http"
"strings"
"syscall"

"github.com/open-lambda/open-lambda/go/common"
"github.com/open-lambda/open-lambda/go/worker/sandbox"
Expand Down Expand Up @@ -34,7 +36,7 @@ type LambdaInstance struct {
//
// 1. Sandbox.Pause/Unpause: discard Sandbox, create new one to handle request
// 2. Sandbox.Create/Channel: discard Sandbox, propagate HTTP 500 to client
// 3. Error inside Sandbox: simply propagate whatever occurred to the client (TODO: restart Sandbox)
// 3. Error inside Sandbox: simply propagate whatever occurred to the client
func (linst *LambdaInstance) Task() {
f := linst.lfunc

Expand Down Expand Up @@ -148,6 +150,13 @@ func (linst *LambdaInstance) Task() {
// copy response out
if err != nil {
linst.TrySendError(req, http.StatusBadGateway, "RoundTrip failed: "+err.Error()+"\n", sb)

// if network refused, the sandbox is likely dead, so discard it.
if errors.Is(err, syscall.ECONNREFUSED) || errors.Is(err, io.EOF) {
f.printf("discard sandbox %s due to NewRequest error: %v", sb.ID(), err)
sb.Destroy("Sandbox failed to service request.")
sb = nil
}
} else {
// copy headers
// (adapted from copyHeaders: https://go.dev/src/net/http/httputil/reverseproxy.go)
Expand Down