Improve code readability#356
Merged
tylerharter merged 26 commits intoopen-lambda:mainfrom Oct 31, 2025
Merged
Conversation
… http server error handling
…n case of nil error
bridgetwu33
added a commit
to bridgetwu33/open-lambda
that referenced
this pull request
Nov 2, 2025
* Added UDS functionality to boss. Can be used in place of TCP ports * Edited UDS to be implemented in worker, undoed changes to boss and config files * Modified workers to use mux for port and UDs, added error channel for http server error handling * Reordered handler and server creation * Reordered removing sockPath * Changed comments with UDS to UNIX domain socket * Refactored waiting for signals from error handling channel * Renamed shutdown function to WriteFinalStats, changed cleanup * Fixed typo * Fixed shutdown logic * Fixed commands.go * Fixed error messages, Main can now return an error, and added panic in case of nil error * Changed commands.go to handle main returning nil * Fixed err variable * Modified NewLambdaServer to take in a serveMux * Modified NewSockServer to take in a serveMux * Moved check for nil error * Changed upCmd to return event.Main * Added comment about upCmd behavior to commands.go * Moved check for nil error * Changed upCmd to return event.Main * Added comment about upCmd behavior to commands.go * Removed unused parameters pidPath and server from WriteFinalStats function --------- Co-authored-by: Bridget Wu <bwu227@cs544-bwu227.cs.wisc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comments to commands.go about the behavior of what urfave/cli will do.