better errors for admin install and pip install (#373)

tylerharter · web-flow · commit e85a79fb5fa4 · 2025-12-17T21:59:34.000-06:00
diff --git a/go/admin/commands.go b/go/admin/commands.go
@@ -136,6 +136,10 @@ func createTarGz(funcDir string) ([]byte, error) {
 			return nil
 		}
 
+		if !info.Mode().IsRegular() {
+			return fmt.Errorf("cannot archive non-regular file %q (mode: %s)", path, info.Mode().String())
+		}
+
 		relPath, err := filepath.Rel(funcDir, path)
 		if err != nil {
 			return fmt.Errorf("unable to compute relative path: %v", err)
diff --git a/go/worker/embedded/packagePullerInstaller.py b/go/worker/embedded/packagePullerInstaller.py
@@ -69,10 +69,11 @@ def f(event):
     if not alreadyInstalled:
         try:
             subprocess.check_output(
-                ['pip3', 'install', '--no-deps', pkg, '--cache-dir', '/tmp/.cache', '-t', '/host/files'])
+                ['pip3', 'install', '--no-deps', pkg, '--cache-dir', '/tmp/.cache', '-t', '/host/files'],
+                stderr=subprocess.STDOUT)
         except subprocess.CalledProcessError as e:
-            print(f'pip install failed with error code {e.returncode}')
-            print(f'Output: {e.output}')
+            output = e.output.decode('utf-8') if e.output else ''
+            raise Exception(f'pip install failed for {pkg} (exit code {e.returncode}): {output}') from None
 
     name = pkg.split("==")[0]
     d = deps("/host/files")
