Merged
Conversation
amagnus
approved these changes
Mar 18, 2024
amagnus
left a comment
There was a problem hiding this comment.
Tested the example from the Readme locally, looks good!
|
@giulio-opal anything else needed to land this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could I get a check on this huge update?
Commands run:
Notable changes:
blackwhich is pretty much standard for python (like gofmt)Evantually I'll set up a github action to automatically release a package on pypi but not in this PR at the moment
To test it do: