Merged
Conversation
andrewsy-opal
force-pushed
the
andrewsy-pypi
branch
from
a2ca375 to
086edef
Compare
giulio-opal
approved these changes
Nov 27, 2024
| @@ -21,8 +21,7 @@ | |||
| # | |||
| # prerequisite: setuptools | |||
| # http://pypi.python.org/pypi/setuptools | |||
| NAME = "opal" | |||
| VERSION = "1.0.0" | |||
Contributor
There was a problem hiding this comment.
why are we removing VERSION from setup
Contributor
Author
There was a problem hiding this comment.
we're adding scm_version so we use the git tags for the version
andrewsy-opal
force-pushed
the
andrewsy-pypi
branch
from
7d58035 to
cbaed38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions:
opal_securitydue toopalbeing taken (Commit 1)opaltoopal_securitymodelsand amodelpackage - seems like the newopenapi-codegenusesmodels, so when I autogenerated the newopal_securitypackage those didn't get ported over, hence they got deleted.