feat: make Vertex AI quotaProjectId optional and support dynamic credential stubs#295
Open
fbricon wants to merge 1 commit into
Open
feat: make Vertex AI quotaProjectId optional and support dynamic credential stubs#295fbricon wants to merge 1 commit into
fbricon wants to merge 1 commit into
Conversation
johnnyfish
force-pushed
the
worktree-optional_quota_projectId
branch
from
0d4a559 to
eeb8974
Compare
Contributor
Author
|
@johnnyfish any update on this one? |
…ential stubs The quotaProjectId (GCP project ID) is optional for Vertex AI authentication. Users can authenticate via service account or authorized user credentials without specifying a project ID. However, the connection validation was incorrectly treating it as required, causing configuration failures when the field was omitted (see openkaiden/kaiden#1882). Changes: - Add `optional` field type to credentials_import connection method - Mark quotaProjectId as optional in both service_account and authorized_user groups - Update validation logic to respect optional field declarations - Support dynamic credential stub generation via functions - Only include quota_project_id in generated ADC stub if actually provided This allows users with minimal credentials to connect to Vertex AI without redundant configuration, while still including the field when available.
fbricon
force-pushed
the
worktree-optional_quota_projectId
branch
from
eeb8974 to
84c0203
Compare
Contributor
|
hey @fbricon sorry for the delay on this one. we'll try to get to it over the weekend and update here. thanks for the patience 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
The quotaProjectId (GCP project ID) is optional for Vertex AI authentication.
Users can authenticate via service account or authorized user credentials
without specifying a quota project ID. However, the connection validation was
incorrectly treating it as required, causing configuration failures when
the field was omitted.
What is the current behavior?
Configuring the vertex ai app from API fails with a "GCP Project ID is required" error. See openkaiden/kaiden#1882
What is the new behavior?
Changes:
optionalfield type to credentials_import connection methodThis allows users with minimal credentials to connect to Vertex AI without
redundant configuration, while still including the field when available.