make pbm screen sizes less hardcoded #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .c files for the pbm bitmap-writing virtual devices contain constants for the output width and height. Previously these constants were used throughout the code, making it impossible to change the width and height without changing these constants. With this change, only the initialization uses the constants, but the rest of the code reads back the width and height from the device struct and uses those. This enables a user of these devices to change the width and height to change the size of the output. This was tested for all three of the pbm devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .c files for the pbm bitmap-writing virtual devices contain
constants for the output width and height. Previously these constants
were used throughout the code, making it impossible to change the width
and height without changing these constants.
With this change, only the initialization uses the constants, but the
rest of the code reads back the width and height from the device
struct and uses those. This enables a user of these devices to change
the width and height to change the size of the output.
This was tested for all three of the pbm devices.