Fix legacy Shogi terminology #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix legacy Shogi terminology.
This PR updates a few comments that appear to be legacy artifacts from a Shogi port.
Specifically, the comments refer to "balls" (a literal translation of "Gyoku", referring to the King in Shogi). These have been corrected to "Kings" to accurately reflect the Chess context and the specific logic of the code, which places the Kings onto the board explicitly before placing the remaining pieces.
Also, this fixes the bit-width (Chess uses 6 bits for 64 squares, not 7 for 81) and replaces Shogi terms ("leading/trailing", "balls") with Chess equivalents ("White/Black", "Kings").